Go try Media Downloader Unleashed!!

If you want to download .m3u8 streams, audio and video files embedded on websites, go give it a try and tell me what you think!

Any feedback (both positive and negative) is apreciated!

  • @villainy@lemmy.world
    link
    fedilink
    English
    2828 days ago

    I can’t tell if this is actually a new project or if you forked, extended, and changed the license of an existing MPL 2.0 project. The latter would be a bad thing.

    You have a commit titled “Full rewrite!!” but I’m not about to go do a comparison to see how “full” it is. If it is indeed a complete clean reimplementation then I would recommend making it a new project so it doesn’t look like you took someone’s FOSS code and relicensed it for yourself.

    • @helloyanis@jlai.luOP
      link
      fedilink
      English
      2828 days ago

      This started as a fork but was fully rewritten from scratch. No code is used from the original repo, so I also chose to make the license more premissive.

      See this commit!

      You have some good points but if I made a new repo from scratch, it would break many links, including links in the add-on’s store page, the add-on itself and search engines. It would also kill every watcher/issue/PR etc so I don’t think it’s really a good idea.

      If you have a clean solution to solve this I’d love to hear it!

    • fmstrat
      link
      fedilink
      English
      1
      edit-2
      22 days ago

      Full rewrites do happen. The first commit of PiKVM is a copy of my repo: https://github.com/pikvm/pikvm/commit/70eebd5c59da26dc3f6ad56730adbb616055f4e5#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R4. I was referenced there for a long time before eventually being removed, and I’m pretty sure by then my code had been fully rewritten.

      Though I did find it funny when LTT covered them and said they complained about a copycat who wasn’t giving them credit 😆